[GitHub] [echarts] pissang commented on a change in pull request #14957: feat(tree): add tree path info to tooltip

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #14957:
URL: https://github.com/apache/echarts/pull/14957#discussion_r633353150



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -112,6 +113,16 @@ export interface TreeSeriesOption extends
     data?: TreeSeriesNodeItemOption[]
 }
 
+interface TreePathInfo {
+    name: string
+    dataIndex: number
+    value: number
+}
+
+interface TreeSeriesCallbackDataParams extends CallbackDataParams {
+    treePathInfo?: TreePathInfo[]

Review comment:
       Ignore the fact that the internal method has been named `wrapTreePathInfo`, is it better to call this property `treeAncestors` when providing to developers? `path` can mean from an arbitrary node to another arbitrary node.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org