[jira] Commented: (OFBIZ-2228) When a virtual product is modified, its variants aren't modified

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679578#action_12679578 ] 

Jacques Le Roux commented on OFBIZ-2228:
----------------------------------------

Eric,

Your (modified) patch is in trunk at revision: 750878  

I changed the name from ServiceVariantEventHandler to ServiceVariantsEventHandler

In Java, please use
    FastList.newInstance() 
instead of 
    new FastList() 
(for easier genericity compatibility)

    if(UtilValidate.isNotEmpty(request.getParameter("productId"))) {
instead of 
    if(request.getParameter("productId") != null && request.getParameter("productId").toString().length() > 0){

put a space before { at end of if(..), see http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions we use http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
Anyway I will soon commit a lot of related changes (not only yours of course) and you will see what I mean in general

Forms : please i18n, l10n,  "Modify Variants"


I wait your patch for "Modify Variants" before closing, thanks !

> When a virtual product is modified, its variants aren't modified
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-2228
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2228
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>         Environment: trunk revision 748987
>            Reporter: Eric DE MAULDE
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ServiceVariant_from-virtual.patch
>
>
> I would like modify product Variants from its Virtual Product
> By example, to :
> -  add (update / delete) category 
> -  add (update / delete) price
> -  add (update / delete) config
> -  add (update / delete) supplier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.