You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/04/16 23:21:08 UTC
[Impala-ASF-CR] Use redirection-aware downloader for pip download.py.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10083
Change subject: Use redirection-aware downloader for pip_download.py.
......................................................................
Use redirection-aware downloader for pip_download.py.
As part of our continuing woes with PyPi infrastructure, we've
now seen redirects. Following redirects seems like the right
thing to do, so I've changed the downloader code to follow them.
I checked that this is available in Python 2.6.
Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
---
M infra/python/deps/pip_download.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/10083/1
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 19:23:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-686: Make pip_download.py honor redirects.
......................................................................
Patch Set 2:
I started https://jenkins.impala.io/job/gerrit-verify-dryrun-external/117/ .
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 02:24:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 17:48:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-686: Make pip_download.py honor redirects.
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 02:30:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Use redirection-aware downloader for pip download.py.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: Use redirection-aware downloader for pip_download.py.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10083/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10083/1//COMMIT_MSG@7
PS1, Line 7: Use redirection-aware downloader for pip_download.py.
Would you mind creating a Jira for this? I suspect we'll want to pick this to the 2.x branch and folks using Impala might also want to backport this to other branches they maintain. A Jira will make it easier to talk about the change.
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 00:02:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Use redirection-aware downloader for pip download.py.
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: Use redirection-aware downloader for pip_download.py.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 23:23:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Fredy Wijaya,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10083
to look at the new patch set (#2).
Change subject: IMPALA-686: Make pip_download.py honor redirects.
......................................................................
IMPALA-686: Make pip_download.py honor redirects.
As part of our continuing woes with PyPi infrastructure, we've now seen
redirects. Following redirects seems like the right thing to do, so I've
changed the downloader code to follow them.
I checked that this is available in Python 2.6.
The build failure signature looks like:
Downloading AllPairs-2.0.1.tar.gz from https://pypi.python.org/packages/04/44/cb85d029b33ddfa7b5a27ae523434c2230f11a89d1f0c73203e9007a6eb0/AllPairs-2.0.1.tar.gz
('http error', 302, 'Found', <httplib.HTTPMessage instance at 0x7fbf7819b050>)
Download failed after several attempts.
Warning: Unable to download Python requirements.
Warning: bootstrap_virtualenv or other Python-based tooling may fail.
Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
---
M infra/python/deps/pip_download.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/10083/2
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
IMPALA-6863: Make pip_download.py honor redirects.
As part of our continuing woes with PyPi infrastructure, we've now seen
redirects. Following redirects seems like the right thing to do, so I've
changed the downloader code to follow them.
I checked that this is available in Python 2.6.
The build failure signature looks like:
Downloading AllPairs-2.0.1.tar.gz from https://pypi.python.org/packages/04/44/cb85d029b33ddfa7b5a27ae523434c2230f11a89d1f0c73203e9007a6eb0/AllPairs-2.0.1.tar.gz
('http error', 302, 'Found', <httplib.HTTPMessage instance at 0x7fbf7819b050>)
Download failed after several attempts.
Warning: Unable to download Python requirements.
Warning: bootstrap_virtualenv or other Python-based tooling may fail.
Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Reviewed-on: http://gerrit.cloudera.org:8080/10083
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Philip Zeyliger <ph...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
---
M infra/python/deps/pip_download.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved; Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-686: Make pip_download.py honor redirects.
......................................................................
Patch Set 2:
(1 comment)
Thanks for the quick fix!
http://gerrit.cloudera.org:8080/#/c/10083/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10083/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-686
Nit: missing digit in Jira bug number (may throw indexers)
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 14:50:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-686: Make pip_download.py honor redirects.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2316/
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 13:52:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#3) to the change originally created by Philip Zeyliger. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
IMPALA-6863: Make pip_download.py honor redirects.
As part of our continuing woes with PyPi infrastructure, we've now seen
redirects. Following redirects seems like the right thing to do, so I've
changed the downloader code to follow them.
I checked that this is available in Python 2.6.
The build failure signature looks like:
Downloading AllPairs-2.0.1.tar.gz from https://pypi.python.org/packages/04/44/cb85d029b33ddfa7b5a27ae523434c2230f11a89d1f0c73203e9007a6eb0/AllPairs-2.0.1.tar.gz
('http error', 302, 'Found', <httplib.HTTPMessage instance at 0x7fbf7819b050>)
Download failed after several attempts.
Warning: Unable to download Python requirements.
Warning: bootstrap_virtualenv or other Python-based tooling may fail.
Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
---
M infra/python/deps/pip_download.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/10083/3
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
Patch Set 3: Code-Review-2
Updated the commit message, thanks for catching this Laszlo. I'm marking this as -2 to make sure that Jenkins doesn't merge PS2 (it shouldn't anyways). Then we can submit it manually once the job reports success.
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 15:48:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 )
Change subject: IMPALA-6863: Make pip_download.py honor redirects.
......................................................................
Patch Set 3: Verified+1 Code-Review+2
Whoops; thanks.
Jenkins came back happy, so pushing ahead.
--
To view, visit http://gerrit.cloudera.org:8080/10083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7551cec43a2d378df7e3cc7d521ace338b56ba2
Gerrit-Change-Number: 10083
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Apr 2018 17:52:49 +0000
Gerrit-HasComments: No