You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/12 18:00:17 UTC

[GitHub] [tvm] leandron commented on a change in pull request #7651: [TVMC] Allow options on --target to contain dots.

leandron commented on a change in pull request #7651:
URL: https://github.com/apache/tvm/pull/7651#discussion_r593359907



##########
File path: python/tvm/driver/tvmc/common.py
##########
@@ -133,7 +133,7 @@ def tokenize_target(target):
 
     target_pattern = (
         r"(\-{0,2}[\w\-]+\=?"
-        r"(?:[\w\+\-]+(?:,[\w\+\-])*|[\'][\w\+\-,\s]+[\']|[\"][\w\+\-,\s]+[\"])*|,)"
+        r"(?:[\w\+\-\.]+(?:,[\w\+\-\.])*|[\'][\w\+\-,\s\.]+[\']|[\"][\w\+\-,\s\.]+[\"])*|,)"

Review comment:
       OK, just for the sake of change tracking, can I put a change in a new PR, splitting this regex into a series of simpler to understand chunks, and explaining each of them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org