You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2006/09/26 15:53:25 UTC

Re: svn commit: r450042 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h


On 09/26/2006 03:29 PM, wrote:
> Author: minfrin
> Date: Tue Sep 26 06:29:09 2006
> New Revision: 450042
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=450042
> Log:
> mod_disk_cache: Make sure that only positive integers are accepted
> for the CacheMaxFileSize and CacheMinFileSize parameters in the
> config file. PR39380 [Niklas Edmundsson <nikke acc.umu.se>]
> 

> Modified: httpd/httpd/trunk/modules/cache/mod_disk_cache.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_disk_cache.h?view=diff&rev=450042&r1=450041&r2=450042
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/mod_disk_cache.h (original)
> +++ httpd/httpd/trunk/modules/cache/mod_disk_cache.h Tue Sep 26 06:29:09 2006
> @@ -88,8 +88,8 @@
>      apr_size_t cache_root_len;
>      int dirlevels;               /* Number of levels of subdirectories */
>      int dirlength;               /* Length of subdirectory names */
> -    apr_size_t minfs;            /* minumum file size for cached files */
> -    apr_size_t maxfs;            /* maximum file size for cached files */
> +    apr_off_t minfs;             /* minimum file size for cached files */
> +    apr_off_t maxfs;             /* maximum file size for cached files */
>  } disk_cache_conf;
>  

Maybe stupid question, but the disk_cache_conf is not part of the API, right? Otherwise I guess we would
need to have some sort of bump here (and I would guess a major one).

Regards

RĂ¼diger


Re: svn commit: r450042 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

Posted by Graham Leggett <mi...@sharp.fm>.
Ruediger Pluem wrote:

> Maybe stupid question, but the disk_cache_conf is not part of the API, right? Otherwise I guess we would
> need to have some sort of bump here (and I would guess a major one).

My understanding is that it isn't part of the API, as nothing depends on 
it, but that is subject to correction?

Regards,
Graham
--