You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/01 11:37:56 UTC

[GitHub] [buildstream] LawrenceHunter1 opened a new pull request, #1669: Add checkout to version in install linux distro

LawrenceHunter1 opened a new pull request, #1669:
URL: https://github.com/apache/buildstream/pull/1669

   Add command to checkout to version tag when installing buildstream. Resolves #1667 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan commented on pull request #1669: Add checkout to version in install linux distro

Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1669:
URL: https://github.com/apache/buildstream/pull/1669#issuecomment-1174793082

   Looks good to me !
   
   Thanks for your contribution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] jjardon commented on a diff in pull request #1669: Add checkout to version in install linux distro

Posted by GitBox <gi...@apache.org>.
jjardon commented on code in PR #1669:
URL: https://github.com/apache/buildstream/pull/1669#discussion_r913039867


##########
doc/source/install_linux_distro.rst:
##########
@@ -127,6 +127,7 @@ git repository and install it as a regular user::
 
   git clone https://gitlab.com/BuildStream/buildstream.git
   cd buildstream
+  git checkout <VERSION>

Review Comment:
   I think you are right; but then you need to explain what "version" is (tag in the git repo), so there is no confusion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] LawrenceHunter1 commented on a diff in pull request #1669: Add checkout to version in install linux distro

Posted by GitBox <gi...@apache.org>.
LawrenceHunter1 commented on code in PR #1669:
URL: https://github.com/apache/buildstream/pull/1669#discussion_r912714326


##########
doc/source/install_linux_distro.rst:
##########
@@ -127,6 +127,7 @@ git repository and install it as a regular user::
 
   git clone https://gitlab.com/BuildStream/buildstream.git
   cd buildstream
+  git checkout <VERSION>

Review Comment:
   That works better for the latest version but it wouldn't resolve the same issue for example 1.4.2 which is also missing the branching command. This is based on my assumption when reading the docs you're reading the latest version, as the Installing from source page does not vary between which version is selected to install. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan merged pull request #1669: Add checkout to version in install linux distro

Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1669:
URL: https://github.com/apache/buildstream/pull/1669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] jjardon commented on a diff in pull request #1669: Add checkout to version in install linux distro

Posted by GitBox <gi...@apache.org>.
jjardon commented on code in PR #1669:
URL: https://github.com/apache/buildstream/pull/1669#discussion_r911908516


##########
doc/source/install_linux_distro.rst:
##########
@@ -127,6 +127,7 @@ git repository and install it as a regular user::
 
   git clone https://gitlab.com/BuildStream/buildstream.git
   cd buildstream
+  git checkout <VERSION>

Review Comment:
   Thanks @LawrenceHunter1 , unless this is replaced at build time with the latest stable tag, I think is better to change this to "git checkout bst-1"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org