You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/02/21 20:21:57 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34281: GH-34280: [C++][Python] Clarify meaning of row_group_size and change default to 1Mi

jorisvandenbossche commented on code in PR #34281:
URL: https://github.com/apache/arrow/pull/34281#discussion_r1113529571


##########
python/pyarrow/parquet/core.py:
##########
@@ -1038,9 +1038,9 @@ def write(self, table_or_batch, row_group_size=None):
         ----------
         table_or_batch : {RecordBatch, Table}
         row_group_size : int, default None
-            Maximum size of each written row group. If None, the
-            row group size will be the minimum of the input
-            table or batch length and 64 * 1024 * 1024.
+            Maximum # of rows in each written row group. If None,

Review Comment:
   ```suggestion
               Maximum number of rows in each written row group. If None,
   ```
   
   (I suppose "#" is quite universal, but just using the word "number" seems even more explicit and not much longer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org