You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 04:07:01 UTC
[GitHub] [airflow] MichaelChirico opened a new pull request #8864: [AIRFLOW-XXXX] remove vestigial sentence fragment in changelog
MichaelChirico opened a new pull request #8864:
URL: https://github.com/apache/airflow/pull/8864
Please update this further if you know what the intended remainder of this sentence was...
PS!! The `Suggest a change on this page` link at https://airflow.apache.org/docs/stable/changelog.html redirects to open a PR on `docs/changelog.rst`, which is actually just a redirect to the edited file -- this kind of defeats the purpose of that link. Is it possible for that link to open a PR on `CHANGELOG.txt` instead?
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] MichaelChirico commented on a change in pull request #8864: [AIRFLOW-XXXX] remove vestigial sentence fragment in changelog
Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on a change in pull request #8864:
URL: https://github.com/apache/airflow/pull/8864#discussion_r427218711
##########
File path: CHANGELOG.txt
##########
@@ -235,7 +235,7 @@ Improvements
- [AIRFLOW-6327] http_hook: Accept json= parameter for payload (#6886)
- [AIRFLOW-6261] flower_basic_auth eligible to _cmd (#6825)
- [AIRFLOW-6238] Filter dags returned by dag_stats
-- [AIRFLOW-5616] Switch PrestoHook from pyhive to prestosql-client to s
+- [AIRFLOW-5616] Switch PrestoHook from pyhive to prestosql-client
Review comment:
Sorry I don't really know the details of these modules. I only noticed the typo, you can feel free to edit as you see fit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle merged pull request #8864: [AIRFLOW-XXXX] remove vestigial sentence fragment in changelog
Posted by GitBox <gi...@apache.org>.
feluelle merged pull request #8864:
URL: https://github.com/apache/airflow/pull/8864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #8864: [AIRFLOW-XXXX] remove vestigial sentence fragment in changelog
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #8864:
URL: https://github.com/apache/airflow/pull/8864#discussion_r425643770
##########
File path: CHANGELOG.txt
##########
@@ -235,7 +235,7 @@ Improvements
- [AIRFLOW-6327] http_hook: Accept json= parameter for payload (#6886)
- [AIRFLOW-6261] flower_basic_auth eligible to _cmd (#6825)
- [AIRFLOW-6238] Filter dags returned by dag_stats
-- [AIRFLOW-5616] Switch PrestoHook from pyhive to prestosql-client to s
+- [AIRFLOW-5616] Switch PrestoHook from pyhive to prestosql-client
Review comment:
```suggestion
- [AIRFLOW-5616] Switch PrestoHook from pyhive to presto-python-client
```
Would be better? @MichaelChirico
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org