You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by PascalSchumacher <gi...@git.apache.org> on 2016/03/06 18:35:24 UTC

[GitHub] groovy pull request: GROOVY-7640:AST Builder should include superc...

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/groovy/pull/284

    GROOVY-7640:AST Builder should include superclass properties

    The code is really ugly, but this is caused by a method with is in `BuilderASTTransformation` but should have been in `ExternalStrategy`. No it can not be moved/modified without breaking binary compatibility.
    
    The pull request is still missing documentation. I will add that if it is accepted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/incubator-groovy 7640_superclass_prop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #284
    
----
commit 18710b9b155646b9de00d821b12db933311503b7
Author: Marc Bogaerts <ma...@telenet.be>
Date:   2015-10-20T15:14:43Z

    GROOVY-7640:AST Builder should include superclass properties

commit fee48bd65d8bf72b440dd66ee5c9735526f060ea
Author: PascalSchumacher <pa...@gmx.net>
Date:   2016-03-06T17:30:12Z

    GROOVY-7640:AST Builder should include superclass properties (closes #152)
    
    make it configurable and make it clear that SimpleStrategy does not support this

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request: GROOVY-7640: AST Builder should include super...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---