You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/28 15:32:40 UTC

[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12862: Fix #12839: Markpoint get raw value

susiwen8 opened a new pull request #12862:
URL: https://github.com/apache/incubator-echarts/pull/12862


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Markpoint value uses raw value
   
   ### Fixed issues
   Close #12839
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <img width="509" alt="Screen Shot 2020-06-28 at 23 29 42" src="https://user-images.githubusercontent.com/20318608/85951672-5249f400-b997-11ea-8698-0aa9a03afc5d.png">
   
   
   
   ### After: How is it fixed in this PR?
   
   <img width="474" alt="Screen Shot 2020-06-28 at 23 29 23" src="https://user-images.githubusercontent.com/20318608/85951689-6d1c6880-b997-11ea-8364-6720359b2073.png">
   
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] susiwen8 closed pull request #12862: Fix #12839: Markpoint get raw value

Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #12862:
URL: https://github.com/apache/incubator-echarts/pull/12862


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] plainheart commented on pull request #12862: Fix #12839: Markpoint get raw value

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #12862:
URL: https://github.com/apache/incubator-echarts/pull/12862#issuecomment-650863534


   How to reproduce the bug shown in screenshot you provided above? Is that just a line series with a log y axis?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12862: Fix #12839: Markpoint get raw value

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12862:
URL: https://github.com/apache/incubator-echarts/pull/12862#issuecomment-650781265


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] susiwen8 commented on pull request #12862: Fix #12839: Markpoint get raw value

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12862:
URL: https://github.com/apache/incubator-echarts/pull/12862#issuecomment-650866741


   ```js
   option = {
       xAxis: {
           type: 'category',
           data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
       },
       yAxis: {
           scale: true,
           type: 'log',
           logBase: 1.1
       },
       dataZoom: [
           {
               type: 'inside',
               start: 50,
               end: 100
           },
           {
               show: true,
               type: 'slider',
               top: '90%',
               start: 50,
               end: 100
           }
       ],
       series: [{
           data: [820, 932, 901, 934, 1290, 1330, 1320],
           type: 'line',
           markPoint: {
               data: [
                   {
                       type: 'max',
                   }
               ],
           },
       }]
   };
   ```
   @plainheart i will add test case later


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org