You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/05 07:54:31 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #370:
[ISSUE #369]feat: remote extra code for internal/utils
xujianhai666 opened a new pull request #370: [ISSUE #369]feat: remote extra code for internal/utils
URL: https://github.com/apache/rocketmq-client-go/pull/370
- remove ringbuffer
- other little extra code
Closes #369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #370:
[ISSUE #369]feat: remote extra code for internal/utils
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #370: [ISSUE #369]feat: remote extra code for internal/utils
URL: https://github.com/apache/rocketmq-client-go/pull/370#issuecomment-570887290
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=h1) Report
> Merging [#370](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/7f7a35d4934dc7b52472fd19d1a3eedb5c73d911?src=pr&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/370/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #370 +/- ##
==========================================
- Coverage 26.27% 25.35% -0.93%
==========================================
Files 47 46 -1
Lines 5537 5424 -113
==========================================
- Hits 1455 1375 -80
+ Misses 3891 3858 -33
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/utils/string.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/370/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdXRpbHMvc3RyaW5nLmdv) | `0% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=footer). Last update [7f7a35d...3bb33bb](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #370: [ISSUE
#369]feat: remote extra code for internal/utils
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #370: [ISSUE #369]feat: remote extra code for internal/utils
URL: https://github.com/apache/rocketmq-client-go/pull/370#issuecomment-570887290
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=h1) Report
> Merging [#370](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/7f7a35d4934dc7b52472fd19d1a3eedb5c73d911?src=pr&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/370/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #370 +/- ##
==========================================
- Coverage 26.27% 25.35% -0.93%
==========================================
Files 47 46 -1
Lines 5537 5424 -113
==========================================
- Hits 1455 1375 -80
+ Misses 3891 3858 -33
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/utils/string.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/370/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdXRpbHMvc3RyaW5nLmdv) | `0% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=footer). Last update [7f7a35d...3bb33bb](https://codecov.io/gh/apache/rocketmq-client-go/pull/370?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #370: [ISSUE
#369]feat: remote extra code for internal/utils
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #370: [ISSUE #369]feat: remote extra code for internal/utils
URL: https://github.com/apache/rocketmq-client-go/pull/370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services