You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/05/16 13:18:39 UTC
[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6023
[FLINK-9383][runtime] Test directories in DistributedCache E2E test
## What is the purpose of the change
With this PR the distributed cache end-to-end test
* also covers the distributed of directories
* runs on every build.
## Brief change log
* add directory parameter to test class
* verification works by looking for a file that the directory should contain
* activate distributed cache e2e test
Additionally, the test now verifies that the file size is identical, to ensure that the correct file was returned.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9383
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6023
----
commit edd70295d6acd1ee3d13a35d7a1bd116d893fa9b
Author: zentol <ch...@...>
Date: 2018-05-15T11:57:56Z
[FLINK-9383][runtime] Test directories in DistributedCache E2E test
commit 31c9d9e4d702dc2a52b9d4b2e49492e00e2865e8
Author: zentol <ch...@...>
Date: 2018-05-15T13:00:50Z
[FLINK-9370][tests] Activate distributed cache end-to-end test
----
---
[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6023
---
[GitHub] flink issue #6023: [FLINK-9383][runtime] Test directories in DistributedCach...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6023
merging.
---
[GitHub] flink pull request #6023: [FLINK-9383][runtime] Test directories in Distribu...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6023#discussion_r190144815
--- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
@@ -93,6 +93,14 @@ if [ $EXIT_CODE == 0 ]; then
EXIT_CODE=$?
fi
+if [ $EXIT_CODE == 0 ]; then
+ printf "\n==============================================================================\n"
+ printf "Running Distributed cache end-to-end test\n"
+ printf "==============================================================================\n"
+ $END_TO_END_DIR/test-scripts/test_streaming_distributed_cache_via_blob.sh
--- End diff --
Should update this to use the new `run_test` utility we have.
---