Re: [PR] Feat: support array_compact function [datafusion-comet]

["kazuyukitanimura (via GitHub)" <gi...@apache.org>]

kazuyukitanimura commented on code in PR #1321:
URL: https://github.com/apache/datafusion-comet/pull/1321#discussion_r1972211143


##########
native/core/src/execution/planner.rs:
##########
@@ -830,6 +830,25 @@ impl PhysicalPlanner {
                 ));
                 Ok(array_has_any_expr)
             }
+            ExprStruct::ArrayCompact(expr) => {

Review Comment:
   Wondering if we can use https://github.com/apache/datafusion-comet/blob/main/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala#L2116
   `scalarExprToProtoWithReturnType` or `scalarExprToProto`
   so that we do not have to define here for every Array related function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org