You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2016/01/05 09:56:25 UTC
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1308
Test to create vpn customer gateway with hostname
While adding vpn customer gateway for site to site vpn connection, cs should also accept host name apart from gateway ip address. It should not be restricted to just ip address.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack vpncgw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1308
----
commit 4b28f5f9e4ed34aae35c47c656078759d2d41188
Author: sanjeevn <sa...@citrix.com>
Date: 2016-01-04T12:44:24Z
Test to verify CS-45057
Bug-Id: CS-45057
Reviewed-by: Self
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212839793
@pavanb018 , those failures are not related to this PR. Can somebody merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212842361
@swill This is a test only PR. 2 LGTMs are there and the CI failures are unrelated to the changes. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212753742
Have done the code review and LGTM !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-202000574
### ACS CI BVT Run
**Sumarry:**
Build Number 134
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=4
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
* test_dedicateGuestVlanRange Failed
* integration.smoke.test_service_offerings.TestCreateServiceOffering
* test_04_change_offering_small Failed
* <nose.suite
* ContextSuite context=TestResetVmOnReboot>:setup Failing since 3 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-168938202
Test to create vpn customer gateway with hostname ... === TestName: test_22_vpn_customer_gw_with_hostname | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 6.321s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-206416810
LGTM thanks @sanju1010 for the addition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212905418
I will merge this today. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Test to create vpn customer
gateway with ...
Posted by Sanjeev N <sa...@apache.org>.
Makes sense. I will add code to list vpn customer gateways and will check
if the response contains the customer gateway or not.
On Tue, Jan 5, 2016 at 3:55 PM, DaanHoogland <gi...@git.apache.org> wrote:
> Github user DaanHoogland commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1308#discussion_r48831039
>
> --- Diff: test/integration/component/test_vpc.py ---
> @@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self):
> "Failed to create VM with first ip address in the CIDR as
> the vm ip"
> )
> return
> +
> + @attr(tags=["advanced", "intervlan"], required_hardware="false")
> + def test_22_vpn_customer_gw_with_hostname(self):
> + """
> + Test to create vpn customer gateway with hostname
> + instead of gateway ip address
> + """
> + try:
> + vpnGw = VpnCustomerGateway.create(
> + self.apiclient,
> + self.services["vpn_customer_gw"],
> + name="test_vpn_customer_gw",
> + gateway="GwWithHostName",
> + cidrlist="10.1.0.0/16"
> + )
> + self.cleanup.append(vpnGw)
> + except Exception as e:
> + self.fail("Creating vpn customer gateway with hostname\
> + Failed with error :%s" % e)
> + return
> --- End diff --
>
> @sanju1010 shouldn't some assertion that the adding succeeded be added
> here? If some programmer decides to silently ignore an error somewhere this
> test becomes useless.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1308#discussion_r48831039
--- Diff: test/integration/component/test_vpc.py ---
@@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self):
"Failed to create VM with first ip address in the CIDR as the vm ip"
)
return
+
+ @attr(tags=["advanced", "intervlan"], required_hardware="false")
+ def test_22_vpn_customer_gw_with_hostname(self):
+ """
+ Test to create vpn customer gateway with hostname
+ instead of gateway ip address
+ """
+ try:
+ vpnGw = VpnCustomerGateway.create(
+ self.apiclient,
+ self.services["vpn_customer_gw"],
+ name="test_vpn_customer_gw",
+ gateway="GwWithHostName",
+ cidrlist="10.1.0.0/16"
+ )
+ self.cleanup.append(vpnGw)
+ except Exception as e:
+ self.fail("Creating vpn customer gateway with hostname\
+ Failed with error :%s" % e)
+ return
--- End diff --
@sanju1010 shouldn't some assertion that the adding succeeded be added here? If some programmer decides to silently ignore an error somewhere this test becomes useless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1308#discussion_r58690197
--- Diff: test/integration/component/test_vpc.py ---
@@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self):
"Failed to create VM with first ip address in the CIDR as the vm ip"
)
return
+
+ @attr(tags=["advanced", "intervlan"], required_hardware="false")
+ def test_22_vpn_customer_gw_with_hostname(self):
+ """
+ Test to create vpn customer gateway with hostname
+ instead of gateway ip address
+ """
+ try:
+ vpnGw = VpnCustomerGateway.create(
+ self.apiclient,
+ self.services["vpn_customer_gw"],
+ name="test_vpn_customer_gw",
+ gateway="GwWithHostName",
+ cidrlist="10.1.0.0/16"
+ )
+ self.cleanup.append(vpnGw)
+ except Exception as e:
+ self.fail("Creating vpn customer gateway with hostname\
+ Failed with error :%s" % e)
+ return
--- End diff --
@DaanHoogland , I have added few validations based on your review comments. Can you please check and give LGTM if you are okay with those changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212839936
@pavanb018 , those failures are not related to this PR. Can somebody please merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---