[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20652: [FEATURE] Add oneDNN support for numpy concatenate operator

[GitBox <gi...@apache.org>]

bartekkuncer commented on a change in pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652#discussion_r724903147



##########
File path: src/operator/nn/concat.cc
##########
@@ -251,8 +257,9 @@ bool SupportMKLDNNConcat(const std::vector<NDArray>& arrs) {
       return false;
     int ndim               = arr.shape().ndim();
     const int mkldnn_ndims = arr.GetMKLDNNData()->get_desc().data.ndims;
-    if (!(ndim == 2 || ndim == 4) || ndim != mkldnn_ndims)
+    if ((ndim != 2 && ndim != 4) || ndim != mkldnn_ndims){

Review comment:
       Missing space.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org