Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

["dbatomic (via GitHub)" <gi...@apache.org>]

dbatomic commented on code in PR #45405:
URL: https://github.com/apache/spark/pull/45405#discussion_r1515983493


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -218,6 +218,6 @@ class DataTypeAstBuilder extends SqlBaseParserBaseVisitor[AnyRef] {
    * Returns a collation name.
    */
   override def visitCollateClause(ctx: CollateClauseContext): String = withOrigin(ctx) {
-    string(visitStringLit(ctx.stringLit))
+    ctx.multipartIdentifier().getText

Review Comment:
   Yeah, let's keep this as an identifier for now. In future, collation name may become multipart identifier, e.g. once we introduce support for user defined collations that are part of a catalog.
   
   But for now, collation name is just an identifier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org