[jira] [Issue Comment Edited] (OFBIZ-3844) Splitting CommonRate and CommonProductRating

["Adrian Crum (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208305#comment-13208305 ] 

Adrian Crum edited comment on OFBIZ-3844 at 2/15/12 9:28 AM:
-------------------------------------------------------------

For English words that have multiple meanings (like "rate") it would be nice to include a hint in the key that indicates which meaning is intended. In this case, something like CommonRelationRate or CommonRatioRate (money per hour, etc) and CommonValueRate or CommonAssessRate (product rating). We could also include notes in the label file to provide a complete description of the label's meaning. Those descriptions could be kept in a <description> element inside the <property> element.


                
      was (Author: adrianc@hlmksw.com):
    For English words that have multiple meanings (like "rate") it would be nice to include a hint in the key that indicates which meaning is intended. In this case, something like CommonRelationRate or CommonRatioRate (rate per hour, etc) and CommonValueRate or CommonAssessRate (product rating). We could also include notes in the label file to provide a complete description of the label's meaning. Those descriptions could be kept in a <description> element inside the <property> element.


                  
> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira