You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (Jira)" <ji...@apache.org> on 2020/07/31 12:23:01 UTC

[jira] [Commented] (WICKET-6808) Cannot add page to AjaxRequestTarget

    [ https://issues.apache.org/jira/browse/WICKET-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168790#comment-17168790 ] 

Sven Meier commented on WICKET-6808:
------------------------------------

Strange that this wasn't noticed before:

https://github.com/apache/wicket/commit/2dc9bd121c62aab1b742e55ce9c2675a8439f6df#diff-5e00c12e074978a2e3f70e52af6fa684

> Cannot add page to AjaxRequestTarget
> ------------------------------------
>
>                 Key: WICKET-6808
>                 URL: https://issues.apache.org/jira/browse/WICKET-6808
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 9.0.0
>            Reporter: Emond Papegaaij
>            Priority: Major
>
> The following code used to work in Wicket 8 and before and refresh the entire page:
> {code}
> @Override
> protected void onSaved(IPartialPageRequestHandler target) {
>     target.add(findPage());
> }
> {code}
> In wicket 9 it gives:
> {code}
> java.lang.IllegalArgumentException: cannot update component that does not have setOutputMarkupId property set to true. Component: [Page class = nl.topicus.keyhub.web.pages.AccountProfielPage, id = 4, render count = 2]
> 	at deployment.keyhub-web-console.war//org.apache.wicket.core.request.handler.AbstractPartialPageRequestHandler.add(AbstractPartialPageRequestHandler.java:71)
> 	at deployment.keyhub-web-console.war//nl.topicus.keyhub.web.components.panel.AccountOverviewPanel$Config2FALink$1.onSaved(AccountOverviewPanel.java:61)
> 	at deployment.keyhub-web-console.war//nl.topicus.keyhub.web.components.contextpanel.TwoFactorAuthenticationConfigPanel$1.onSave(TwoFactorAuthenticationConfigPanel.java:59)
> 	at deployment.keyhub-web-console.war//nl.topicus.keyhub.web.components.panel.ContextPopupSubmitLink.onSubmit(ContextPopupSubmitLink.java:24)
> 	at deployment.keyhub-web-console.war//nl.topicus.keyhub.web.components.form.UpgradingSubmitLink.doSubmit(UpgradingSubmitLink.java:44)
> 	at deployment.keyhub-web-console.war//nl.topicus.keyhub.web.components.form.UpgradingSubmitLink.onSubmit(UpgradingSubmitLink.java:37)
> {code}
> Calling {{setOutputMarkupId(true)}} on the page fixes the error, but IMHO does not make much sense.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)