You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2014/06/10 22:02:30 UTC
Re: git commit: [flex-utilities] [refs/heads/develop] - use flag to keep cleanup from running twice
Hi,
Not 100% sure - but seems a little suspect to me in it may try to clean uo before the last step???
Justin
Re: git commit: [flex-utilities] [refs/heads/develop] - use flag to
keep cleanup from running twice
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Jun 10, 2014 1:09 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> No, cleanup is called in this scenario after the last step. But htting
> the close button to close the main window also calls cleanup, which it
> should if you bail out before you get to the last step. I suppose I could
> have added a flag about whether we'd finished up the last step and have
> the close button handler not call cleanup. Or maybe the better fix is to
> close the log window when the close button is clicked then you wouldn't
> see this (which has been this way for a while I think). I wonder if there
> is a reason to leave the log window up if you close the main window.
No real reason. We probably just forgot to implement that.
Thanks,
Om
>
> -Alex
>
> On 6/10/14 1:02 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> >Hi,
> >
> >Not 100% sure - but seems a little suspect to me in it may try to clean
> >uo before the last step???
> >
> >Justin
>
Re: git commit: [flex-utilities] [refs/heads/develop] - use flag to
keep cleanup from running twice
Posted by Alex Harui <ah...@adobe.com>.
No, cleanup is called in this scenario after the last step. But htting
the close button to close the main window also calls cleanup, which it
should if you bail out before you get to the last step. I suppose I could
have added a flag about whether we'd finished up the last step and have
the close button handler not call cleanup. Or maybe the better fix is to
close the log window when the close button is clicked then you wouldn't
see this (which has been this way for a while I think). I wonder if there
is a reason to leave the log window up if you close the main window.
-Alex
On 6/10/14 1:02 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Not 100% sure - but seems a little suspect to me in it may try to clean
>uo before the last step???
>
>Justin