You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ca...@apache.org on 2022/09/20 02:49:43 UTC
[dolphinscheduler] 03/03: [Improvement-11291][sql] Improvement the log output while executing multiple sql statements (#11292)
This is an automated email from the ASF dual-hosted git repository.
caishunfeng pushed a commit to branch 3.1.0-prepare
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
commit 806ad1d98c5f0d5937ad8db4673d3125cea8458d
Author: rickchengx <38...@users.noreply.github.com>
AuthorDate: Tue Sep 20 09:30:27 2022 +0800
[Improvement-11291][sql] Improvement the log output while executing multiple sql statements (#11292)
---
.../main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
index f884f46e5e..d7fbfb87aa 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
@@ -290,7 +290,6 @@ public class SqlTask extends AbstractTaskExecutor {
private String executeQuery(Connection connection, SqlBinds sqlBinds, String handlerType) throws Exception {
try (PreparedStatement statement = prepareStatementAndBind(connection, sqlBinds)) {
- logger.info("{} statement execute query, for sql: {}", handlerType, sqlBinds.getSql());
ResultSet resultSet = statement.executeQuery();
return resultProcess(resultSet);
}
@@ -362,7 +361,7 @@ public class SqlTask extends AbstractTaskExecutor {
ParameterUtils.setInParameter(entry.getKey(), stmt, prop.getType(), prop.getValue());
}
}
- logger.info("prepare statement replace sql : {} ", stmt);
+ logger.info("prepare statement replace sql : {}, sql parameters : {}", sqlBinds.getSql(), sqlBinds.getParamsMap());
return stmt;
} catch (Exception exception) {
throw new TaskException("SQL task prepareStatementAndBind error", exception);