You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/26 09:00:30 UTC

[GitHub] godfreyhe opened a new pull request #7836: [FLINK-11714][table-planner-blink] Add cost model for both batch and streaming

godfreyhe opened a new pull request #7836: [FLINK-11714][table-planner-blink] Add cost model for both batch and streaming
URL: https://github.com/apache/flink/pull/7836
 
 
   
   ## What is the purpose of the change
   
   This commit adds cost model for both batch and streaming. 
   
   Calcite's default cost model only contains ROWS, IO and CPU, and does not take IO and CPU into account when the cost is compared. 
   
   There are two improvements:
   1. Add NETWORK and MEMORY to represents distribution cost and memory usage.
   2. Implements new cost comparison strategy based on VolcanoCost
   
   ## Brief change log
     -*extends NETWORK and MEMORY factors in AbstractFlinkCost*
     -*implements FlinkBatchCost and FlinkStreamCost based on VolcanoCost*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added FlinkBatchCostTest and FlinkStreamCostTest*
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (JavaDocs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services