You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/21 17:11:39 UTC

[GitHub] [superset] AAfghahi commented on a change in pull request #15793: feat: Begin incorporation of email report modal to Charts

AAfghahi commented on a change in pull request #15793:
URL: https://github.com/apache/superset/pull/15793#discussion_r674178551



##########
File path: superset-frontend/src/explore/components/ExploreChartHeader.jsx
##########
@@ -205,6 +223,19 @@ export class ExploreChartHeader extends React.PureComponent {
             isRunning={chartStatus === 'loading'}
             status={CHART_STATUS_MAP[chartStatus]}
           />
+          <span
+            role="button"
+            title={t('Schedule email report')}
+            tabIndex={0}
+            className="action-button"
+            onClick={this.showReportModal}

Review comment:
       I'm game either way. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org