[GitHub] [kafka] ableegoldman commented on a change in pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463752139



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##########
@@ -144,15 +144,35 @@ private boolean allSubscriptionsEqual(Set<String> allTopics,
         return true;
     }
 
+
+    /**
+     * This constrainedAssign optimizes the assignment algorithm when all consumers were subscribed to same set of topics.
+     * The method includes the following steps:
+     *
+     * 1. Reassign as many previously owned partitions as possible

Review comment:
       ```suggestion
        * 1. Reassign as many previously owned partitions as possible, up to the maxQuota
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org