You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2023/04/21 14:27:35 UTC

[skywalking] branch polish created (now c49c60b33d)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch polish
in repository https://gitbox.apache.org/repos/asf/skywalking.git


      at c49c60b33d Polish log of alert GRPCCallback

This branch includes the following new commits:

     new c49c60b33d Polish log of alert GRPCCallback

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[skywalking] 01/01: Polish log of alert GRPCCallback

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch polish
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit c49c60b33d2fb59766ad94985b567aac6cbf3f7f
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Fri Apr 21 22:27:14 2023 +0800

    Polish log of alert GRPCCallback
---
 .../skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
index de85df8ad4..1eb3246441 100644
--- a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
+++ b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/GRPCCallback.java
@@ -143,11 +143,11 @@ public class GRPCCallback implements AlarmCallback {
         if (grpcAlarmSetting == null) {
             if (grpcClient != null) {
                 grpcClient.shutdown();
+                log.debug("gRPC alarm hook target is empty, shutdown the old gRPC client.");
             }
             alarmServiceStub = null;
             alarmSetting = null;
 
-            log.warn("gRPC alarm hook settings about host is empty, shutdown the old gRPC client.");
             return;
         }
 
@@ -155,6 +155,7 @@ public class GRPCCallback implements AlarmCallback {
             alarmSetting = grpcAlarmSetting;
             if (grpcClient != null) {
                 grpcClient.shutdown();
+                log.debug("gRPC alarm hook target is changed, shutdown the old gRPC client.");
             }
             grpcClient = new GRPCClient(grpcAlarmSetting.getTargetHost(), grpcAlarmSetting.getTargetPort());
             grpcClient.connect();