You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Christian Schneider (Jira)" <ji...@apache.org> on 2020/02/11 14:23:00 UTC
[jira] [Commented] (SLING-9050) Failures to extract or install the
packages are not reported to the upper layer
[ https://issues.apache.org/jira/browse/SLING-9050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034484#comment-17034484 ]
Christian Schneider commented on SLING-9050:
--------------------------------------------
[~marett] I see the failed extract only does a warn message. So I propose we instead throw the exception and let the whole import of the distribution package fail. So the issue is reported clearly. Do you agree?
> Failures to extract or install the packages are not reported to the upper layer
> -------------------------------------------------------------------------------
>
> Key: SLING-9050
> URL: https://issues.apache.org/jira/browse/SLING-9050
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
> Reporter: Dominik Süß
> Assignee: Timothee Maret
> Priority: Major
>
> https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/0b977dbd4782291c14f4173e76ef1451568100a2/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java#L100-L102
> swallows the exception and causes a failed extraction to not be reported and staying unnoticed. While a feature to autounblock and dispose packages from a queue if they fail to extract might be desirable there would be the need of a feedback channel reporting such disposed packages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)