You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/19 10:37:02 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #764: feat: update the comment of getty/listener
AlexStocks commented on a change in pull request #764:
URL: https://github.com/apache/dubbo-go/pull/764#discussion_r491373876
##########
File path: remoting/getty/listener.go
##########
@@ -64,35 +64,35 @@ func (s *rpcSession) GetReqNum() int32 {
// RpcClientHandler
// //////////////////////////////////////////
-// RpcClientHandler ...
+// RpcClientHandler getty rpc client handler
Review comment:
the comment is nonsense. use "nolint" instead.
##########
File path: remoting/getty/listener.go
##########
@@ -64,35 +64,35 @@ func (s *rpcSession) GetReqNum() int32 {
// RpcClientHandler
// //////////////////////////////////////////
-// RpcClientHandler ...
+// RpcClientHandler getty rpc client handler
type RpcClientHandler struct {
conn *gettyRPCClient
}
-// NewRpcClientHandler ...
+// NewRpcClientHandler new getty rpc client handler
Review comment:
the comment is nonsense. use "nolint" instead.
##########
File path: remoting/getty/listener.go
##########
@@ -169,7 +169,7 @@ type RpcServerHandler struct {
server *Server
}
-// NewRpcServerHandler ...
+// NewRpcServerHandler new rpc server handler
Review comment:
the comment is nonsense. use "nolint" instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org