You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/01 17:41:46 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #17070: Handle changing schemas in Storage API sink

TheNeuralBit commented on a change in pull request #17070:
URL: https://github.com/apache/beam/pull/17070#discussion_r840794938



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinationsTableRow.java
##########
@@ -91,9 +95,32 @@ public Descriptor getSchemaDescriptor() {
       }
 
       @Override
-      public Message toMessage(T element) {
-        return TableRowToStorageApiProto.messageFromTableRow(
-            descriptor, formatFunction.apply(element));
+      public Message toMessage(T element) throws Exception {

Review comment:
       Note the comment above:
   
   > I wonder if those should be explicitly handled in this function then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org