[GitHub] [spark] vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add multi-cluster Kafka delegation token

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add multi-cluster Kafka delegation token
URL: https://github.com/apache/spark/pull/24305#discussion_r280578665
 
 

 ##########
 File path: docs/structured-streaming-kafka-integration.md
 ##########
 @@ -703,11 +703,99 @@ Kafka broker configuration):
 
 After obtaining delegation token successfully, Spark distributes it across nodes and renews it accordingly.
 Delegation token uses `SCRAM` login module for authentication and because of that the appropriate
-`spark.kafka.sasl.token.mechanism` (default: `SCRAM-SHA-512`) has to be configured. Also, this parameter
+`spark.kafka.clusters.${cluster}.sasl.token.mechanism` (default: `SCRAM-SHA-512`) has to be configured. Also, this parameter
 must match with Kafka broker configuration.
 
 When delegation token is available on an executor it can be overridden with JAAS login configuration.
 
+#### Configuration
+
+Delegation tokens can be obtained from multiple clusters and <code>${cluster}</code> is an arbitrary unique identifier which helps to group different configurations.
+
+<table class="table">
+<tr><th>Property Name</th><th>Default</th><th>Meaning</th></tr>
+  <tr>
+    <td><code>spark.kafka.clusters.${cluster}.bootstrap.servers</code></td>
 
 Review comment:
   What do you think of changing these names?
   
   I think "bootstrap.servers" and "target.bootstrap.servers" ends up being a little confusing. Maybe call this "auth.servers" to make it more explicit that these are only used for the initial authentication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org