You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/05/01 17:05:32 UTC

[PR] Fix wrong compare function in lb_command.c (celix)

pnoltes opened a new pull request, #533:
URL: https://github.com/apache/celix/pull/533

   Also renames the compare function pointer typedef to celix_array_list_compare_entries_fp instead of celix_array_list_sort_entries_fp and adds the framework bundle to the `lb` result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix wrong compare function in lb_command.c (celix)

Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes merged PR #533:
URL: https://github.com/apache/celix/pull/533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix wrong compare function in lb_command.c (celix)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #533:
URL: https://github.com/apache/celix/pull/533#issuecomment-1529977375

   ## [Codecov](https://codecov.io/gh/apache/celix/pull/533?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#533](https://codecov.io/gh/apache/celix/pull/533?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f202f6) into [master](https://codecov.io/gh/apache/celix/commit/d07ee87f519156dce42314d5f37a5b985faabecc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d07ee87) will **increase** coverage by `0.47%`.
   > The diff coverage is `84.61%`.
   
   > :exclamation: Current head 6f202f6 differs from pull request most recent head 9761046. Consider uploading reports for the commit 9761046 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #533      +/-   ##
   ==========================================
   + Coverage   75.64%   76.11%   +0.47%     
   ==========================================
     Files         225      225              
     Lines       34451    34458       +7     
   ==========================================
   + Hits        26059    26228     +169     
   + Misses       8392     8230     -162     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [bundles/shell/shell/src/lb\_command.c](https://codecov.io/gh/apache/celix/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9zaGVsbC9zaGVsbC9zcmMvbGJfY29tbWFuZC5j) | `89.47% <75.00%> (+0.83%)` | :arrow_up: |
   | [libs/utils/src/array\_list.c](https://codecov.io/gh/apache/celix/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy91dGlscy9zcmMvYXJyYXlfbGlzdC5j) | `89.27% <100.00%> (ø)` | |
   
   ... and [6 files with indirect coverage changes](https://codecov.io/gh/apache/celix/pull/533/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org