You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jeff Hair <jh...@acm.org> on 2014/04/21 18:20:33 UTC
Review Request 20522: Bugfix CLOUDSTACK-6467: User VM state listener
publishes to event bus incompletely
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20522/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
This patch fixes both issues in the bug CLOUDSTACK-6467. It is a simple change to UserVmStateListener that moves the publishOnEventBus call to before returning in the post transition event, and the publishOnEventBus method now puts the status into the description map to be published on the bus.
Diffs
-----
server/src/com/cloud/vm/UserVmStateListener.java 202391f
Diff: https://reviews.apache.org/r/20522/diff/
Testing
-------
Complete single-node environment set up in virtual machine with KVM, with a test listener to check that the UserVmStateListener sends the status as part of the event description map, as well as receives post-transition events for virtual routers from the event bus.
Thanks,
Jeff Hair
Re: Review Request 20522: Bugfix CLOUDSTACK-6467: User VM state listener
publishes to event bus incompletely
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20522/#review41302
-----------------------------------------------------------
Ship it!
pushed to master commit 9c4de764f74bffd5cd547f8514d4a6897fb961c2
- Murali Reddy
On April 21, 2014, 4:20 p.m., Jeff Hair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20522/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 4:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch fixes both issues in the bug CLOUDSTACK-6467. It is a simple change to UserVmStateListener that moves the publishOnEventBus call to before returning in the post transition event, and the publishOnEventBus method now puts the status into the description map to be published on the bus.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmStateListener.java 202391f
>
> Diff: https://reviews.apache.org/r/20522/diff/
>
>
> Testing
> -------
>
> Complete single-node environment set up in virtual machine with KVM, with a test listener to check that the UserVmStateListener sends the status as part of the event description map, as well as receives post-transition events for virtual routers from the event bus.
>
>
> Thanks,
>
> Jeff Hair
>
>