You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:43:05 UTC
[GitHub] [dolphinscheduler] huagetai opened a new pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
huagetai opened a new pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076
## Add the project's branding banner "dolphin scheduler" at launch
Add the brand banner of the project when the project starts, which will help strengthen the brand awareness of the project.
## Brief change log
- Add "banner.txt" to src/main/resources
- Modify src/main/resources/application.yaml
delete
```
spring:
main:
banner-mode: off
```
add
```
spring:
banner:
charset: UTF-8
image:
width: 20
```
## Verify this pull request
This pull request is code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huagetai removed a comment on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
huagetai removed a comment on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1082700932
merger to #9273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1074721435
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9076](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9424caf) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/bf1f959f587ff7dfb268a21b2c99b72388ad778a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf1f959) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9424caf differs from pull request most recent head 7e70cfd. Consider uploading reports for the commit 7e70cfd to get more accurate results
```diff
@@ Coverage Diff @@
## dev #9076 +/- ##
============================================
- Coverage 39.80% 39.76% -0.04%
+ Complexity 4264 4262 -2
============================================
Files 808 808
Lines 32545 32545
Branches 3646 3646
============================================
- Hits 12953 12941 -12
- Misses 18365 18378 +13
+ Partials 1227 1226 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `49.43% <0.00%> (-13.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf1f959...7e70cfd](https://codecov.io/gh/apache/dolphinscheduler/pull/9076?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huagetai commented on a change in pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
huagetai commented on a change in pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#discussion_r833880297
##########
File path: dolphinscheduler-standalone-server/src/main/resources/banner.txt
##########
@@ -0,0 +1,12 @@
+${AnsiColor.CYAN}
+====================================================================================
+ _____ _ _ _ _____ _ _ _
+| __ \ | | | | (_) / ____| | | | | | |
+| | | | ___ | |_ __ | |__ _ _ __ | (___ ___| |__ ___ __| |_ _| | ___ _ __
+| | | |/ _ \| | '_ \| '_ \| | '_ \ \___ \ / __| '_ \ / _ \/ _` | | | | |/ _ \ '__|
+| |__| | (_) | | |_) | | | | | | | | ____) | (__| | | | __/ (_| | |_| | | __/ |
+|_____/ \___/|_| .__/|_| |_|_|_| |_| |_____/ \___|_| |_|\___|\__,_|\__,_|_|\___|_|
+ | |
+ |_|
+=====================================================================================
+Dolphinscheduler 版本: ${application.version}
Review comment:
English is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#discussion_r833874206
##########
File path: dolphinscheduler-standalone-server/src/main/resources/banner.txt
##########
@@ -0,0 +1,12 @@
+${AnsiColor.CYAN}
+====================================================================================
+ _____ _ _ _ _____ _ _ _
+| __ \ | | | | (_) / ____| | | | | | |
+| | | | ___ | |_ __ | |__ _ _ __ | (___ ___| |__ ___ __| |_ _| | ___ _ __
+| | | |/ _ \| | '_ \| '_ \| | '_ \ \___ \ / __| '_ \ / _ \/ _` | | | | |/ _ \ '__|
+| |__| | (_) | | |_) | | | | | | | | ____) | (__| | | | __/ (_| | |_| | | __/ |
+|_____/ \___/|_| .__/|_| |_|_|_| |_| |_____/ \___|_| |_|\___|\__,_|\__,_|_|\___|_|
+ | |
+ |_|
+=====================================================================================
+Dolphinscheduler 版本: ${application.version}
Review comment:
I don't suggest using Chinese words in the terminal, which might have unnecessary encoding issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on a change in pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#discussion_r838279120
##########
File path: dolphinscheduler-standalone-server/src/main/resources/banner.txt
##########
@@ -0,0 +1,12 @@
+${AnsiColor.CYAN}
+====================================================================================
+ _____ _ _ _ _____ _ _ _
+| __ \ | | | | (_) / ____| | | | | | |
+| | | | ___ | |_ __ | |__ _ _ __ | (___ ___| |__ ___ __| |_ _| | ___ _ __
+| | | |/ _ \| | '_ \| '_ \| | '_ \ \___ \ / __| '_ \ / _ \/ _` | | | | |/ _ \ '__|
+| |__| | (_) | | |_) | | | | | | | | ____) | (__| | | | __/ (_| | |_| | | __/ |
+|_____/ \___/|_| .__/|_| |_|_|_| |_| |_____/ \___|_| |_|\___|\__,_|\__,_|_|\___|_|
+ | |
+ |_|
+=====================================================================================
+Dolphinscheduler 版本: ${application.version}
Review comment:
not resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1074725014
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9076&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9076&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9076&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
caishunfeng closed pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huagetai commented on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
huagetai commented on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1082700932
merger to #9273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huagetai commented on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
huagetai commented on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1082702448
@caishunfeng merged to #9273. this close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #9076: Add the project's branding banner "dolphin scheduler" at launch
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on pull request #9076:
URL: https://github.com/apache/dolphinscheduler/pull/9076#issuecomment-1082795488
> @caishunfeng merged to #9273. this close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org