You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/09 17:20:39 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #2222: Test AWS 2 SNS properly

ppalaga opened a new pull request #2222:
URL: https://github.com/apache/camel-quarkus/pull/2222


   @llowinge something for you again :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #2222: Test AWS 2 SNS properly

Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #2222:
URL: https://github.com/apache/camel-quarkus/pull/2222#issuecomment-776209734


   Maybe you could rename the classes named `*Sqs*`, since they handle now both *SQS* and *SNS* ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #2222: Test AWS 2 SNS properly

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2222:
URL: https://github.com/apache/camel-quarkus/pull/2222


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2222: Test AWS 2 SNS properly

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2222:
URL: https://github.com/apache/camel-quarkus/pull/2222#issuecomment-776295368


   > Maybe you could rename the classes named `*Sqs*`, since they handle now both _SQS_ and _SNS_ ?
   
   You are right, but I have already done some changes in my workspace that make amending this PR very impractical. I'll try to do it in my next PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org