You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/07/21 14:43:13 UTC
Review Request 61035: Adding travis.yml to run the tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Travis is a CI system, which can automatically run and validate the source code
Diffs
-----
.travis.yml PRE-CREATION
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/61035/diff/1/
Testing
-------
Successful build on travis:
https://travis-ci.org/gzsombor/ranger/builds/255768716
Thanks,
Zsombor Gegesy
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Zsombor Gegesy <gz...@gmail.com>.
> On July 24, 2017, 2:18 p.m., Colm O hEigeartaigh wrote:
> > What happens if you leave out the M2_HOME part? I'd rather not depend on specific Maven versions.
> > You could add in a section on notifications:
> >
> > notifications:
> > email:
> > - dev@ranger.apache.org
I could remove it, and it worked without a hiccup. I put originally there, because initially I've tried run the build with an older Ubuntu 12 image, which doesn't have recent enough Maven, so I had to manually these flags, luckily Ubuntu 14 has a newer Maven by default.
Currently travis notifies the original commiter and author about the build failure, which I think is good enough. I would rather not spam the dev list, when I try building a commit in my repo :)
- Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181216
-----------------------------------------------------------
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61035/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 9:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1706
> https://issues.apache.org/jira/browse/RANGER-1706
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Travis is a CI system, which can automatically run and validate the source code
>
>
> Diffs
> -----
>
> .travis.yml PRE-CREATION
> pom.xml 7ae0217
>
>
> Diff: https://reviews.apache.org/r/61035/diff/2/
>
>
> Testing
> -------
>
> Successful build on travis:
> https://travis-ci.org/gzsombor/ranger/builds/255768716
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181216
-----------------------------------------------------------
What happens if you leave out the M2_HOME part? I'd rather not depend on specific Maven versions.
You could add in a section on notifications:
notifications:
email:
- dev@ranger.apache.org
- Colm O hEigeartaigh
On July 21, 2017, 2:50 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61035/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:50 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1706
> https://issues.apache.org/jira/browse/RANGER-1706
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Travis is a CI system, which can automatically run and validate the source code
>
>
> Diffs
> -----
>
> .travis.yml PRE-CREATION
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/61035/diff/1/
>
>
> Testing
> -------
>
> Successful build on travis:
> https://travis-ci.org/gzsombor/ranger/builds/255768716
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181552
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61035/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 9:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1706
> https://issues.apache.org/jira/browse/RANGER-1706
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Travis is a CI system, which can automatically run and validate the source code
>
>
> Diffs
> -----
>
> .travis.yml PRE-CREATION
> pom.xml 7ae0217
>
>
> Diff: https://reviews.apache.org/r/61035/diff/2/
>
>
> Testing
> -------
>
> Successful build on travis:
> https://travis-ci.org/gzsombor/ranger/builds/255768716
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Zsombor Gegesy <gz...@gmail.com>.
> On July 26, 2017, 12:08 p.m., Colm O hEigeartaigh wrote:
> > Was there a specific reason for the surefire upgrade?
Yes, it is needed for disabling the failing test cases
- Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181450
-----------------------------------------------------------
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61035/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 9:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1706
> https://issues.apache.org/jira/browse/RANGER-1706
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Travis is a CI system, which can automatically run and validate the source code
>
>
> Diffs
> -----
>
> .travis.yml PRE-CREATION
> pom.xml 7ae0217
>
>
> Diff: https://reviews.apache.org/r/61035/diff/2/
>
>
> Testing
> -------
>
> Successful build on travis:
> https://travis-ci.org/gzsombor/ranger/builds/255768716
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181450
-----------------------------------------------------------
Was there a specific reason for the surefire upgrade?
- Colm O hEigeartaigh
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61035/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 9:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1706
> https://issues.apache.org/jira/browse/RANGER-1706
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Travis is a CI system, which can automatically run and validate the source code
>
>
> Diffs
> -----
>
> .travis.yml PRE-CREATION
> pom.xml 7ae0217
>
>
> Diff: https://reviews.apache.org/r/61035/diff/2/
>
>
> Testing
> -------
>
> Successful build on travis:
> https://travis-ci.org/gzsombor/ranger/builds/255768716
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/
-----------------------------------------------------------
(Updated July 25, 2017, 9:10 p.m.)
Review request for ranger.
Changes
-------
The unnecessary maven environment variables are removed
Bugs: RANGER-1706
https://issues.apache.org/jira/browse/RANGER-1706
Repository: ranger
Description
-------
Travis is a CI system, which can automatically run and validate the source code
Diffs (updated)
-----
.travis.yml PRE-CREATION
pom.xml 7ae0217
Diff: https://reviews.apache.org/r/61035/diff/2/
Changes: https://reviews.apache.org/r/61035/diff/1-2/
Testing
-------
Successful build on travis:
https://travis-ci.org/gzsombor/ranger/builds/255768716
Thanks,
Zsombor Gegesy
Re: Review Request 61035: RANGER-1706: Adding travis.yml to run the
tests
Posted by Zsombor Gegesy <gz...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/
-----------------------------------------------------------
(Updated July 21, 2017, 2:50 p.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-1706: Adding travis.yml to run the tests
Bugs: RANGER-1706
https://issues.apache.org/jira/browse/RANGER-1706
Repository: ranger
Description
-------
Travis is a CI system, which can automatically run and validate the source code
Diffs
-----
.travis.yml PRE-CREATION
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/61035/diff/1/
Testing
-------
Successful build on travis:
https://travis-ci.org/gzsombor/ranger/builds/255768716
Thanks,
Zsombor Gegesy