You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 23:55:29 UTC
[GitHub] [airflow] kaxil opened a new issue #13378: Add a flag to list all Upgrade Check Rules
kaxil opened a new issue #13378:
URL: https://github.com/apache/airflow/issues/13378
It would be nice to have a list of all the available uprade-checks rules:
```
❯ airflow upgrade_check --help
usage: airflow upgrade_check [-h] [-s SAVE] [-i IGNORE] [-c CONFIG]
optional arguments:
-h, --help show this help message and exit
-s SAVE, --save SAVE Saves the result to the indicated file. The file
format is determined by the file extension.
-i IGNORE, --ignore IGNORE
Ignore a rule. Can be used multiple times.
-c CONFIG, --config CONFIG
Path to upgrade check config yaml file.
```
example:
```
❯ airflow upgrade_check --list
- Check for latest versions of apache-airflow and checker
- Remove airflowAirflowMacroPlugin class
- Chain between DAG and operator not allowed
- Connectionconn_id is not unique
- Connectionconn_type is not nullable
- Ensure users are not using custom metaclasses in custom operators
- Fernet is enabled by default
- GCP service account key deprecation
- Unify hostname_callable option in core section
- Changes in import paths of hooks, operators, sensors and others
- Users must delete deprecated configs for KubernetesExecutor
- Legacy UI is deprecated by default
- Logging configuration has been moved to new section
- Removal of Mesos Executor
- No additional argument allowed in BaseOperator
- Users must set a kubernetespod_template_file value
- SendGrid email uses old airflowcontrib module
- Changes in import path of remote task handlers
- Jinja Template Variables cannot be undefined
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280406
> If I might add, it would be also useful to list the rule class name so people know which rules correspond to which class if they want to ignore them!
Was just adding that too :) literally did it few seconds back :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280671
> > Was just adding that too :) literally did it few seconds back :)
>
> Ha, forgive my impatience 😁 ! I'm working on #13349 and #13350 right now, feel free to assign this to me if you wanted!
Awesome, assigned it to you 😄 -- thanks. Looking forward to reviewing your PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280671
> > Was just adding that too :) literally did it few seconds back :)
>
> Ha, forgive my impatience 😁 ! I'm working on #13349 and #13350 right now, feel free to assign this to me if you wanted!
Awesome, assigned it to you :) Looking forward to reviewing your PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #13378:
URL: https://github.com/apache/airflow/issues/13378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280406
> If I might add, it would be also useful to list the rule class name so people know which rules correspond to which class if they want to ignore them!
Was just adding that too :) literally did it few seconds beack :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla edited a comment on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
madison-ookla edited a comment on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280150
If I might add, it would be also useful to list the rule class name so people know which rules correspond to which class if they want to ignore them! I had the darndest time trying to find the name of the class when I was looking for a rule to ignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280535
> Was just adding that too :) literally did it few seconds back :)
Ha, forgive my impatience 😁 ! I'm working on #13349 and #13350 right now, feel free to assign this to me if you wanted!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280150
If I might add, it would be also useful to list the rule class name so people know which rules correspond to which class if they want to ignore them!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-752280406
> If I might add, it would be also useful to list the rule class name so people know which rules correspond to which class if they want to ignore them!
Was just adding that too :) literally did it few seconds back :)
>This allows users to know the progress of their checks and an easy way to ignore a check beforehand (if we list an id too, example PodTemplateFileRule).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13378: Add a flag to list all Upgrade Check Rules
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13378:
URL: https://github.com/apache/airflow/issues/13378#issuecomment-756434448
Closed by https://github.com/apache/airflow/pull/13392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org