You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/10/27 07:30:32 UTC

[GitHub] mistercrunch opened a new pull request #3726: [WiP] Bumping react-select to rc10

mistercrunch opened a new pull request #3726: [WiP] Bumping react-select to rc10
URL: https://github.com/apache/incubator-superset/pull/3726
 
 
   Attempt at bumping `react-select` to rc10 to remove React warning messages. Also cleaning up the copy-pasta of `select.less`.
   
   Somehow the css is a little off and can't figure it out. I think it has to do with this hack here:
   https://github.com/apache/incubator-superset/blob/master/superset/assets/stylesheets/superset.less#L344
   
   <img width="186" alt="screen shot 2017-10-27 at 12 28 28 am" src="https://user-images.githubusercontent.com/487433/32092521-cb65d174-baad-11e7-88c8-bfcff548c6d3.png">
   
   @graceguo-supercat can you help getting this through?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services