You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/06/21 19:35:39 UTC
Review Request 35717: Add reservations support to master's state.json
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692
Repository: mesos
Description
-------
Add reservations support to master's state.json
Diffs
-----
src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
Diff: https://reviews.apache.org/r/35717/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by haosdent huang <ha...@gmail.com>.
> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > <https://reviews.apache.org/r/35717/diff/1/?file=989232#file989232line88>
> >
> > `s/key/role/`
>
> haosdent huang wrote:
> I think use key may be more general. Because this method not only could be used to generate "role -> resources" json, also could be used to generate "principal -> resources" json. Or other any keys.
>
> Michael Park wrote:
> Ok, sounds good to me.
Thank you for your fast reply!
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
-----------------------------------------------------------
On June 21, 2015, 6:07 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
>
> (Updated June 21, 2015, 6:07 p.m.)
>
>
> Review request for mesos, Adam B and Michael Park.
>
>
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add reservations support to master's state.json
>
>
> Diffs
> -----
>
> src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
> src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
> src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
>
> Diff: https://reviews.apache.org/r/35717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by haosdent huang <ha...@gmail.com>.
> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > <https://reviews.apache.org/r/35717/diff/1/?file=989232#file989232line88>
> >
> > `s/key/role/`
I think use key may be more general. Because this method not only could be used to generate "role -> resources" json, also could be used to generate "principal -> resources" json. Or other any keys.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
-----------------------------------------------------------
On June 21, 2015, 6:04 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
>
> (Updated June 21, 2015, 6:04 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add reservations support to master's state.json
>
>
> Diffs
> -----
>
> src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
> src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
> src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
>
> Diff: https://reviews.apache.org/r/35717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by Michael Park <mc...@gmail.com>.
> On June 21, 2015, 5:56 p.m., Michael Park wrote:
> > src/common/http.cpp, line 88
> > <https://reviews.apache.org/r/35717/diff/1/?file=989232#file989232line88>
> >
> > `s/key/role/`
>
> haosdent huang wrote:
> I think use key may be more general. Because this method not only could be used to generate "role -> resources" json, also could be used to generate "principal -> resources" json. Or other any keys.
Ok, sounds good to me.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
-----------------------------------------------------------
On June 21, 2015, 6:07 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
>
> (Updated June 21, 2015, 6:07 p.m.)
>
>
> Review request for mesos, Adam B and Michael Park.
>
>
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add reservations support to master's state.json
>
>
> Diffs
> -----
>
> src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
> src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
> src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
>
> Diff: https://reviews.apache.org/r/35717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review88703
-----------------------------------------------------------
Thanks for doing this! Looks good to me overall.
src/common/http.cpp (line 88)
<https://reviews.apache.org/r/35717/#comment141259>
`s/key/role/`
src/master/http.cpp (line 234)
<https://reviews.apache.org/r/35717/#comment141260>
This is a bug from before, we should use `slave.totalResources` here instead.
- Michael Park
On June 21, 2015, 5:35 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
>
> (Updated June 21, 2015, 5:35 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-692
> https://issues.apache.org/jira/browse/MESOS-692
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add reservations support to master's state.json
>
>
> Diffs
> -----
>
> src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
> src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
> src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
>
> Diff: https://reviews.apache.org/r/35717/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
-----------------------------------------------------------
(Updated June 21, 2015, 6:04 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692
Repository: mesos
Description
-------
Add reservations support to master's state.json
Diffs (updated)
-----
src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
Diff: https://reviews.apache.org/r/35717/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 35717: Add reservations support to master's
state.json
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/
-----------------------------------------------------------
(Updated June 21, 2015, 6:02 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-692
https://issues.apache.org/jira/browse/MESOS-692
Repository: mesos
Description
-------
Add reservations support to master's state.json
Diffs (updated)
-----
src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8
src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
Diff: https://reviews.apache.org/r/35717/diff/
Testing
-------
Thanks,
haosdent huang