You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/15 23:46:09 UTC

[GitHub] [kafka] kirktrue opened a new pull request, #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

kirktrue opened a new pull request, #13000:
URL: https://github.com/apache/kafka/pull/13000

   The OAuth code to generate the `Authentication` header was incorrectly using the URL-safe base64 encoder. For client IDs and/or secrets with dashes and/or plus signs would not be encoded correctly, leading to the OAuth server to reject the credentials.
   
   This change uses the correct base64 encoder, per RFC-7617.
   
   Thanks to Endre Vig for the proposed fix.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kirktrue commented on pull request #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

Posted by GitBox <gi...@apache.org>.
kirktrue commented on PR #13000:
URL: https://github.com/apache/kafka/pull/13000#issuecomment-1353884809

   @omkreddy - would you be willing to review? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy merged pull request #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

Posted by GitBox <gi...@apache.org>.
omkreddy merged PR #13000:
URL: https://github.com/apache/kafka/pull/13000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org