You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/27 01:41:03 UTC

[GitHub] [skywalking] haoyann opened a new issue #6459: Remove spring-could plugin empty intercept

haoyann opened a new issue #6459:
URL: https://github.com/apache/skywalking/issues/6459


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [x] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v21x.TcpClientConstructorInterceptor` did nothing, should remove it .
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] haoyann commented on issue #6459: Remove spring-cloud plugin empty intercept

Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6459:
URL: https://github.com/apache/skywalking/issues/6459#issuecomment-786987380


   Thank you for your answer, I looked at the code again and it is used in `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v21x.HttpClientFinalizerConstructorInterceptor#onConstruct`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6459: Remove spring-could plugin empty intercept

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6459:
URL: https://github.com/apache/skywalking/issues/6459#issuecomment-786983193


   Are you sure? Empty instrumentation always mean requiring dynamic `EnhancedInstance` interface.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] haoyann closed issue #6459: Remove spring-cloud plugin empty intercept

Posted by GitBox <gi...@apache.org>.
haoyann closed issue #6459:
URL: https://github.com/apache/skywalking/issues/6459


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org