You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/12 12:40:51 UTC

[GitHub] [rocketmq] terrance-swn opened a new pull request, #4296: [ISSUE #4292] Add description to the community list of README file

terrance-swn opened a new pull request, #4296:
URL: https://github.com/apache/rocketmq/pull/4296

**Make sure set the target branch to `develop`**

## What is the purpose of the change

Add description to the community list of README file.

## Brief changelog

XX

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] caigy merged pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

caigy merged PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] caigy commented on a diff in pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

caigy commented on code in PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#discussion_r873183354


##########
README.md:
##########
@@ -35,20 +35,21 @@ It offers a variety of features:
 
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ.
-* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. 
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table.
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
 * [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
 * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
-* [RocketMQ Operator](https://github.com/apache/rocketmq-operator)
-* [RocketMQ Docker](https://github.com/apache/rocketmq-docker)
-* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ
-* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems
-* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt)
-* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals)
+* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes.

Review Comment:
   1. It seems `Providing` should be used instead of `Provides`.
   2. `an Apache RocketMQ cluster` is more appropriate. 



##########
README.md:
##########
@@ -35,20 +35,21 @@ It offers a variety of features:
 
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ.
-* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. 
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table.
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.

Review Comment:
   Seems not more descriptive than the original ones. Maybe you can refer to corresponding projects for more specific description. 



##########
README.md:
##########
@@ -35,20 +35,21 @@ It offers a variety of features:
 
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ.
-* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. 
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table.
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
 * [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
 * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
-* [RocketMQ Operator](https://github.com/apache/rocketmq-operator)
-* [RocketMQ Docker](https://github.com/apache/rocketmq-docker)
-* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ
-* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems
-* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt)
-* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals)
+* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes.
+* [RocketMQ Docker](https://github.com/apache/rocketmq-docker): The Git repo of the Docker Image for Apache RocketMQ.
+* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ.
+* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems.
+* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP.
+* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors.

Review Comment:
   1. Please use `Apache RocketMQ` for consistency.
   2. Could you please explain the meaning of 'warehouse' here? It is a bit confusing.
   3. rocketmq-externals is a repository for incubator projects related to Apache RocketMQ, not limited to connectors. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

duhenglucky commented on PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#issuecomment-1125592478

   @hzh0425 @terrance-swn It's a good practice to add a short description for each eco-repo, but would you like resolve the conflicts first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

hzh0425 commented on code in PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#discussion_r871927613


##########
README.md:
##########
@@ -37,18 +37,18 @@ It offers a variety of features:
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams)
 * [RocketMQ Flink](https://github.com/apache/rocketmq-flink)
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
 * [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
 * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
-* [RocketMQ Operator](https://github.com/apache/rocketmq-operator)
-* [RocketMQ Docker](https://github.com/apache/rocketmq-docker)
+* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes.
+* [RocketMQ Docker](https://github.com/apache/rocketmq-docker): The Git repo of the Docker Image for Apache RocketMQ.
 * [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard)
 * [RocketMQ Connect](https://github.com/apache/rocketmq-connect)
-* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt)
-* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals)
+* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP.
+* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors.
 

Review Comment:
   Have you discussed this practice with the community?



##########
README.md:
##########
@@ -37,18 +37,18 @@ It offers a variety of features:
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams)
 * [RocketMQ Flink](https://github.com/apache/rocketmq-flink)
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
 * [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
 * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
-* [RocketMQ Operator](https://github.com/apache/rocketmq-operator)
-* [RocketMQ Docker](https://github.com/apache/rocketmq-docker)
+* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes.
+* [RocketMQ Docker](https://github.com/apache/rocketmq-docker): The Git repo of the Docker Image for Apache RocketMQ.
 * [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard)
 * [RocketMQ Connect](https://github.com/apache/rocketmq-connect)
-* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt)
-* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals)
+* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP.
+* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors.
 

Review Comment:
   Have you discussed this practice with the community?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

hzh0425 commented on code in PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#discussion_r871927613


##########
README.md:
##########
@@ -37,18 +37,18 @@ It offers a variety of features:
 ## Apache RocketMQ Community
 * [RocketMQ Streams](https://github.com/apache/rocketmq-streams)
 * [RocketMQ Flink](https://github.com/apache/rocketmq-flink)
-* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp)
-* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go)
+* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client.
+* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client.
 * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python)
 * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs)
 * [RocketMQ Spring](https://github.com/apache/rocketmq-spring)
 * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter)
-* [RocketMQ Operator](https://github.com/apache/rocketmq-operator)
-* [RocketMQ Docker](https://github.com/apache/rocketmq-docker)
+* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes.
+* [RocketMQ Docker](https://github.com/apache/rocketmq-docker): The Git repo of the Docker Image for Apache RocketMQ.
 * [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard)
 * [RocketMQ Connect](https://github.com/apache/rocketmq-connect)
-* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt)
-* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals)
+* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP.
+* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors.
 

Review Comment:
   Have you discussed this practice with the community?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#issuecomment-1126498548

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4296](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab55809) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9445b788757c437a0cb85964f81f9ab4af9ef90f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9445b78) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4296      +/-   ##
   =============================================
   - Coverage      48.18%   48.06%   -0.13%     
   + Complexity      5085     5069      -16     
   =============================================
     Files            642      642              
     Lines          42780    42780              
     Branches        5599     5599              
   =============================================
   - Hits           20614    20561      -53     
   - Misses         19650    19707      +57     
   + Partials        2516     2512       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../broker/subscription/SubscriptionGroupManager.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc3Vic2NyaXB0aW9uL1N1YnNjcmlwdGlvbkdyb3VwTWFuYWdlci5qYXZh) | `64.70% <0.00%> (-16.48%)` | :arrow_down: |
   | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `39.96% <0.00%> (-3.88%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
   | [...e/rocketmq/remoting/netty/NettyRemotingServer.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `57.34% <0.00%> (-1.90%)` | :arrow_down: |
   | [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `72.05% <0.00%> (-1.48%)` | :arrow_down: |
   | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `45.48% <0.00%> (-1.13%)` | :arrow_down: |
   | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `43.75% <0.00%> (-0.79%)` | :arrow_down: |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `49.64% <0.00%> (-0.71%)` | :arrow_down: |
   | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `75.19% <0.00%> (-0.52%)` | :arrow_down: |
   | [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `57.92% <0.00%> (-0.50%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/rocketmq/pull/4296/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9445b78...ab55809](https://codecov.io/gh/apache/rocketmq/pull/4296?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#issuecomment-1126498063

   
   [![Coverage Status](https://coveralls.io/builds/49114043/badge)](https://coveralls.io/builds/49114043)
   
   Coverage decreased (-0.3%) to 51.914% when pulling **ab5580981568fc6305808cd23f846523dc5f899b on terrance-swn:develop** into **9445b788757c437a0cb85964f81f9ab4af9ef90f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4296: [ISSUE #4292] Add description to the community list of README file

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4296:
URL: https://github.com/apache/rocketmq/pull/4296#issuecomment-1126498069

   
   [![Coverage Status](https://coveralls.io/builds/49114043/badge)](https://coveralls.io/builds/49114043)
   
   Coverage decreased (-0.3%) to 51.914% when pulling **ab5580981568fc6305808cd23f846523dc5f899b on terrance-swn:develop** into **9445b788757c437a0cb85964f81f9ab4af9ef90f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org