[GitHub] [spark] cloud-fan commented on a diff in pull request #40602: [SPARK-42978][SQL] Derby&PG: RENAME cannot qualify a new-table-Name with a schema-Name

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40602:
URL: https://github.com/apache/spark/pull/40602#discussion_r1153979914


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -398,10 +398,24 @@ abstract class JdbcDialect extends Serializable with Logging {
    * @param newTable New name of the table.
    * @return The SQL statement to use for renaming the table.
    */
+  @deprecated("Please use renameTable method with identifiers", "3.5.0")

Review Comment:
   ```suggestion
     @deprecated("Please override renameTable method with identifiers", "3.5.0")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org