[jira] Commented: (HADOOP-1826) Side classes should be moved to separate files

["Raghu Angadi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524237 ] 

Raghu Angadi commented on HADOOP-1826:
--------------------------------------

Owen, could you clarify if this is a real problem for ant or just a readablity issue.

I consciously decided to keep BlockCrcUpgrade classes in one file since others mostly never have to the read the code, so did not want to pollute the dfs/ directory.

> Side classes should be moved to separate files
> ----------------------------------------------
>
>                 Key: HADOOP-1826
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1826
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.15.0
>
>
> The following classes are "side" classes that aren't in files with the same name. This caused problems last night because ant compiled things in the wrong order and couldn't find one of the relevant classes. I think it would make the code easier to read and understand if you could always find a given class in the expected place.
> {code}
> > find src/java -name '*.java' | xargs grep '^class' | sed -e 's|\([a-zA-Z0-9/]*/\)\([^/.]*\)[.]java:class \([^ <]*\).*|\1 \2 \3|' | awk '{if ($2 != $3) print $1$2".java",$3}'
> src/java/org/apache/hadoop/mapred/BasicTypeSorterBase.java MRSortResultIterator
> src/java/org/apache/hadoop/dfs/BlockCommand.java DatanodeCommand
> src/java/org/apache/hadoop/dfs/Storage.java StorageInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java DNBlockUpgradeInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeUtils
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectDatanode
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectNamenode
> src/java/org/apache/hadoop/dfs/INode.java INodeDirectory
> src/java/org/apache/hadoop/dfs/INode.java INodeFile
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.