You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/06/05 08:46:57 UTC
[Bug 53360] New: SXSSF removes characters before escaped Unicode
control character
https://issues.apache.org/bugzilla/show_bug.cgi?id=53360
Priority: P2
Bug ID: 53360
Assignee: dev@poi.apache.org
Summary: SXSSF removes characters before escaped Unicode
control character
Severity: normal
Classification: Unclassified
OS: All
Reporter: martin.andersson@purplescout.se
Hardware: All
Status: NEW
Version: 3.8
Component: SXSSF
Product: POI
Created attachment 28885
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28885&action=edit
Fix for SheetDataWriter and test case
SXSSF replaces Unicode control characters with '?' but fails to write out the
preceding characters.
A cell containing "value\u0019" should be "value?" but is now "?".
Attached is a fix and a test case to prove it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53360] SXSSF removes characters before escaped Unicode control
character
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53360
--- Comment #1 from Martin Andersson <ma...@purplescout.se> ---
This issue has been unanswered for a few weeks now. Is there anything more you
need to review the patch?
The patch is only three lines of code and it makes the SXSSF api consistent
with the XSSF api when it comes to escaping cell string values.
When SXSSF writes string cells it iterates over the string locking for
characters that need escaping. The valid characters are kept in a buffer and
are flushed when an escaped character is written. The flushing part is missing
for Unicode control characters. That's what this patch adds.
We have used the patch in production for five weeks now without any insidents.
Please let me know if you need anything more.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53360] SXSSF removes characters before escaped Unicode control
character
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53360
--- Comment #2 from Yegor Kozlov <ye...@dinom.ru> ---
I will give my feedback within a few days.
Thanks for your patience.
Yegor
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53360] SXSSF removes characters before escaped Unicode control
character
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53360
Martin Andersson <ma...@purplescout.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.andersson@purplescou
| |t.se
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 53360] SXSSF removes characters before escaped Unicode control
character
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53360
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Yegor Kozlov <ye...@dinom.ru> ---
patch applied in r1362093
Regards,
Yegor
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org