You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "trevor211 (via GitHub)" <gi...@apache.org> on 2023/03/14 05:03:25 UTC
[GitHub] [bookkeeper] trevor211 opened a new pull request, #3864: fix wrong implementation for `percentile` in bookkeeper-benchmark
trevor211 opened a new pull request, #3864:
URL: https://github.com/apache/bookkeeper/pull/3864
According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong.
Descriptions of the changes in this PR:
### Motivation
When I did benchmark tests using bookeeper-benchmark, I found that the percentile output seemed wrong. After checking the source code I think the current implementation is wrong.
### Changes
Fix function `percentile` in bookkeeper-benchmark to make it corrent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3864: fix wrong implementation for `percentile` in bookkeeper-benchmark
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3864:
URL: https://github.com/apache/bookkeeper/pull/3864#issuecomment-1477076070
## [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3864?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3864](https://codecov.io/gh/apache/bookkeeper/pull/3864?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5cd426) into [master](https://codecov.io/gh/apache/bookkeeper/commit/ebf3108d54774f01934ba1c5bfb177dc94c8169d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebf3108) will **decrease** coverage by `25.41%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3864 +/- ##
=============================================
- Coverage 65.25% 39.84% -25.41%
+ Complexity 6504 3943 -2561
=============================================
Files 473 473
Lines 40987 40987
Branches 5243 5243
=============================================
- Hits 26745 16332 -10413
- Misses 12040 22894 +10854
+ Partials 2202 1761 -441
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `39.84% <ø> (-0.04%)` | :arrow_down: |
| client | `?` | |
| replication | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 267 files with indirect coverage changes](https://codecov.io/gh/apache/bookkeeper/pull/3864/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix wrong implementation for `percentile` in bookkeeper-benchmark [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #3864:
URL: https://github.com/apache/bookkeeper/pull/3864#issuecomment-2045098304
Sorry for my late reply, Could you please rebase the master code? There may has some flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix wrong implementation for `percentile` in bookkeeper-benchmark [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #3864:
URL: https://github.com/apache/bookkeeper/pull/3864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix wrong implementation for `percentile` in bookkeeper-benchmark [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #3864:
URL: https://github.com/apache/bookkeeper/pull/3864#issuecomment-2068845071
@trevor211 Thanks for your contribution, looking forward to your future contributions. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org