You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/05 15:03:45 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #212: [YUNIKORN-433] Extend configwatcher expiration
codecov[bot] commented on pull request #212:
URL: https://github.com/apache/incubator-yunikorn-core/pull/212#issuecomment-703691505
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=h1) Report
> Merging [#212](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/1e23202cef2a9bc0798290135ab7570cc4d0a51e?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 60.82% 60.84% +0.01%
==========================================
Files 67 67
Lines 5688 5728 +40
==========================================
+ Hits 3460 3485 +25
- Misses 2087 2101 +14
- Partials 141 142 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/queue\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3F1ZXVlX2luZm8uZ28=) | `68.99% <0.00%> (-0.88%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `50.00% <ø> (+2.46%)` | :arrow_up: |
| [pkg/common/configs/configwatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3dhdGNoZXIuZ28=) | `84.74% <75.00%> (+1.41%)` | :arrow_up: |
| [pkg/common/configs/config.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `68.96% <100.00%> (ø)` | |
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `86.87% <100.00%> (ø)` | |
| [pkg/cache/cachetestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NhY2hldGVzdHV0aWxzLmdv) | `51.51% <0.00%> (-3.33%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=footer). Last update [29d6c82...f98e220](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org