[jira] [Commented] (SENTRY-1602) Code cleanup for Sentry JSON message factory for hive notifications

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847793#comment-15847793 ] 

Hadoop QA commented on SENTRY-1602:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12850335/SENTRY-1602.3-sentry-ha-redesign.patch against sentry-ha-redesign.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2293/console

This message is automatically generated.

> Code cleanup for Sentry JSON message factory for hive notifications
> -------------------------------------------------------------------
>
>                 Key: SENTRY-1602
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1602
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: sentry-ha-redesign
>            Reporter: Nachiket Vaidya
>            Assignee: Nachiket Vaidya
>              Labels: patch-available
>             Fix For: sentry-ha-redesign
>
>         Attachments: SENTRY-1602.0.patch, SENTRY-1602.1-sentry-ha-redesign.patch, SENTRY-1602.2-sentry-ha-redesign.patch, SENTRY-1602.3-sentry-ha-redesign.patch
>
>
> The following changes are done as part of code cleanup:
> o Removed the classes JSONAlterPartitionMessage and JSONAlterTableMessage as corresponding classes are present in Hive.
> o Changed member variable location to locations in SentryJSONDropPartitionMessage as SentryJSONDropPartitionMessage can hold list of dropped partitions.
> o removed unnecessary code that was not required for compilation (e.g. casting, commented code)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)