You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/07/25 12:03:51 UTC
Review Request 23921: Ambari server should inform the agent whether to use
two-way ssl when registering
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Bugs: AMBARI-6608
https://issues.apache.org/jira/browse/AMBARI-6608
Repository: ambari
Description
-------
Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
ambari-agent/src/main/python/ambari_agent/security.py c4cb746
ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 497d3f7
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionType.java PRE-CREATION
Diff: https://reviews.apache.org/r/23921/diff/
Testing
-------
Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.483s]
[INFO] Ambari Server ..................................... FAILURE [9:33.696s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.743s
[INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
[INFO] Final Memory: 23M/319M
[INFO] ------------------------------------------------------------------------
same tests fail on trunk
Agent tests:
----------------------------------------------------------------------
Ran 288 tests in 3.663s
OK
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] 291 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.625s
[INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
[INFO] Final Memory: 11M/149M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review49453
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On July 30, 2014, 5:02 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 5:02 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/Register.py fada031
> ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
> ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
> ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
> ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review49718
-----------------------------------------------------------
Not committing patch because tests start failing on latest trunk
- Dmitro Lisnichenko
On Aug. 4, 2014, 4:59 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 4:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/Register.py fada031
> ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
> ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
> ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
> ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review49728
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 4, 2014, 12:59 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 12:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/Register.py fada031
> ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
> ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
> ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
> ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review49779
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Aug. 6, 2014, 9:42 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:42 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/Register.py fada031
> ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
> ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
> ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
> ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d61b1b7
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 6:42 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
Tests pass now
[INFO] Ambari Views ...................................... SUCCESS [5.906s]
[INFO] Ambari Server ..................................... SUCCESS [16:25.752s]
[INFO] Ambari Agent ...................................... SUCCESS [4.406s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:36.641s
[INFO] Finished at: Wed Aug 06 21:19:59 FET 2014
[INFO] Final Memory: 27M/230M
[INFO] ------------------------------------------------------------------------
Bugs: AMBARI-6608
https://issues.apache.org/jira/browse/AMBARI-6608
Repository: ambari
Description
-------
Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
ambari-agent/src/main/python/ambari_agent/Register.py fada031
ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
ambari-agent/src/main/python/ambari_agent/security.py c4cb746
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d61b1b7
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
Diff: https://reviews.apache.org/r/23921/diff/
Testing
-------
Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.483s]
[INFO] Ambari Server ..................................... FAILURE [9:33.696s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.743s
[INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
[INFO] Final Memory: 23M/319M
[INFO] ------------------------------------------------------------------------
same tests fail on trunk
Agent tests:
----------------------------------------------------------------------
Ran 288 tests in 3.663s
OK
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] 291 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.625s
[INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
[INFO] Final Memory: 11M/149M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review49690
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Aug. 4, 2014, 4:59 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 4:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
> ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/Register.py fada031
> ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
> ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
> ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
> ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 4:59 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-6608
https://issues.apache.org/jira/browse/AMBARI-6608
Repository: ambari
Description
-------
Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
ambari-agent/src/main/python/ambari_agent/Register.py fada031
ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
ambari-agent/src/main/python/ambari_agent/security.py c4cb746
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
Diff: https://reviews.apache.org/r/23921/diff/
Testing
-------
Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.483s]
[INFO] Ambari Server ..................................... FAILURE [9:33.696s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.743s
[INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
[INFO] Final Memory: 23M/319M
[INFO] ------------------------------------------------------------------------
same tests fail on trunk
Agent tests:
----------------------------------------------------------------------
Ran 288 tests in 3.663s
OK
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] 291 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.625s
[INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
[INFO] Final Memory: 11M/149M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/
-----------------------------------------------------------
(Updated July 30, 2014, 2:02 p.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Bugs: AMBARI-6608
https://issues.apache.org/jira/browse/AMBARI-6608
Repository: ambari
Description
-------
Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
ambari-agent/src/main/python/ambari_agent/Register.py fada031
ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
ambari-agent/src/main/python/ambari_agent/security.py c4cb746
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 7a65c81
Diff: https://reviews.apache.org/r/23921/diff/
Testing
-------
Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.483s]
[INFO] Ambari Server ..................................... FAILURE [9:33.696s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.743s
[INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
[INFO] Final Memory: 23M/319M
[INFO] ------------------------------------------------------------------------
same tests fail on trunk
Agent tests:
----------------------------------------------------------------------
Ran 288 tests in 3.663s
OK
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] 291 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.625s
[INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
[INFO] Final Memory: 11M/149M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/
-----------------------------------------------------------
(Updated July 30, 2014, 10:58 a.m.)
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Changes
-------
uploaded a new patch
Bugs: AMBARI-6608
https://issues.apache.org/jira/browse/AMBARI-6608
Repository: ambari
Description
-------
Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 688dc74
ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 34d7816
ambari-agent/src/main/python/ambari_agent/Heartbeat.py b6a7b87
ambari-agent/src/main/python/ambari_agent/HostCleanup.py 16596f3
ambari-agent/src/main/python/ambari_agent/HostInfo.py 8064794
ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
ambari-agent/src/main/python/ambari_agent/Register.py fada031
ambari-agent/src/main/python/ambari_agent/hostname.py 56031fc
ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
ambari-agent/src/main/python/ambari_agent/security.py c4cb746
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 897493a
ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 5216447
ambari-agent/src/test/python/ambari_agent/TestController.py dd92e06
ambari-agent/src/test/python/ambari_agent/TestHostname.py 9d96090
ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
ambari-agent/src/test/python/ambari_agent/TestSecurity.py 8b11063
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java eb34a77
ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java PRE-CREATION
Diff: https://reviews.apache.org/r/23921/diff/
Testing
-------
Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.483s]
[INFO] Ambari Server ..................................... FAILURE [9:33.696s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.743s
[INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
[INFO] Final Memory: 23M/319M
[INFO] ------------------------------------------------------------------------
same tests fail on trunk
Agent tests:
----------------------------------------------------------------------
Ran 288 tests in 3.663s
OK
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] 291 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.625s
[INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
[INFO] Final Memory: 11M/149M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 23921: Ambari server should inform the agent whether to
use two-way ssl when registering
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23921/#review48723
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionType.java
<https://reviews.apache.org/r/23921/#comment85479>
Can you please make endpoint name more general (like connection properties or similar), this will better reflect response content and allow future extension.
- Myroslav Papirkovskyy
On July 25, 2014, 1:03 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23921/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 1:03 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-6608
> https://issues.apache.org/jira/browse/AMBARI-6608
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, agent uses a implicit mechanism to decide whether to use two-way ssl. It tries to connect normally and if it fails it switches to using two-way ssl.
> We should improve this setup to make it explicit. The initial GET call agent makes (server:8440/cert/ca) should return a response providing the requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use this data and decide on the nature of the connection.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py bf68616
> ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875
> ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea
> ambari-agent/src/main/python/ambari_agent/security.py c4cb746
> ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6
> ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 497d3f7
> ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java 9d4e603
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionType.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23921/diff/
>
>
> Testing
> -------
>
> Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.483s]
> [INFO] Ambari Server ..................................... FAILURE [9:33.696s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9:37.743s
> [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014
> [INFO] Final Memory: 23M/319M
> [INFO] ------------------------------------------------------------------------
>
> same tests fail on trunk
>
> Agent tests:
> ----------------------------------------------------------------------
> Ran 288 tests in 3.663s
>
> OK
> [INFO]
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/examples/*
> [INFO] Exclude: src/test/python/dummy*.txt
> [INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
> [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
> [INFO] Exclude: src/main/python/ambari_agent/imports.txt
> [INFO] Exclude: **/*.erb
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.pydevproject
> [INFO] 291 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.625s
> [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014
> [INFO] Final Memory: 11M/149M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>