You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by j....@gmail.com on 2014/08/14 22:07:21 UTC

Review Request 24711: HIVE-7734: Join stats annotation rule is not updating columns statistics correctly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24711/
-----------------------------------------------------------

Review request for hive, Gunther Hagleitner and Harish Butani.


Bugs: HIVE-7734
    https://issues.apache.org/jira/browse/HIVE-7734


Repository: hive-git


Description
-------

HIVE-7679 is not doing the correct thing. The scale down/up factor updating column stats was wrong as ratio = newRowCount/oldRowCount is always infinite (oldRowCount = 0). The old row count should be retrieved from parent corresponding to the current column whose statistics is being updated.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 838d6b1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 99b26bd 
  ql/src/test/results/clientpositive/union20.q.out 663d128 

Diff: https://reviews.apache.org/r/24711/diff/


Testing
-------


Thanks,

Prasanth_J