You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2009/03/24 00:49:50 UTC
[jira] Created: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Patches are not applied to the WAR distribution
-----------------------------------------------
Key: SYNAPSE-524
URL: https://issues.apache.org/jira/browse/SYNAPSE-524
Project: Synapse
Issue Type: Bug
Reporter: Andreas Veithen
Assignee: Andreas Veithen
Fix For: 1.3
I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688539#action_12688539 ]
Asankha C. Perera commented on SYNAPSE-524:
-------------------------------------------
I would include instructions into the WAR documentation, to add the lib/patches into the system classpath, or whereever necessary - depending on the App server.
This will be a requirement anyway for future patches, so its best to delegate this to the sys admins
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688741#action_12688741 ]
Asankha C. Perera commented on SYNAPSE-524:
-------------------------------------------
It could be any classpath, which will be checked before the web apps.. However the point I want to make is that there is no advantage we gain by trying to put the extracted classes of patches into WEB-INF/classes, since for any patches to be applied later on, that will anyway require manual intervention. These tasks are best left for the admins.
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688622#action_12688622 ]
Andreas Veithen commented on SYNAPSE-524:
-----------------------------------------
Why into the system classpath?
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688531#action_12688531 ]
Ruwan Linton commented on SYNAPSE-524:
--------------------------------------
Well, in that case we need to put the classes but not the jar file isn't it... So this requires some maven work at the build time but this is a MUST fix to me.
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved SYNAPSE-524.
-------------------------------------
Resolution: Fixed
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-524) Patches are not applied to the WAR
distribution
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712542#action_12712542 ]
Andreas Veithen commented on SYNAPSE-524:
-----------------------------------------
Adding them to the system classpath will not work, at least not with the current way we provide the patches. The reason is that our patches only contain individual classes. If we add them to the system classpath, they will not see their dependencies which reside in the web app. The patches must be loaded from the same class loader from which the original JARs are loaded. In addition deploying the patches to the system classloader may have unpredictable impact on other applications running on the server (which may use a different version of the original JAR!).
> Patches are not applied to the WAR distribution
> -----------------------------------------------
>
> Key: SYNAPSE-524
> URL: https://issues.apache.org/jira/browse/SYNAPSE-524
> Project: Synapse
> Issue Type: Bug
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Fix For: 1.3
>
>
> I noticed that the patches (e.g. httpcore-nio-4.0-patch-httpcore-193.jar) are bundled with the ZIP distribution, but not with the Web application. This could cause inconsistent behavior between a standalone deployment and a deployment into an application server.
> According to the servlet spec (SRV.9.5 in v2.4), "The Web application class loader must load classes from the WEB-INF/classes directory first, and then from library JARs in the WEB-INF/lib directory." This gives a hint how to bundle these patches into the WAR so that the modified classes have priority.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org