[GitHub] [incubator-dubbo] chickenlj opened pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["chickenlj (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

## Brief changelog

Add default compareTo implementation to Router interface
remove compateTo from impl class

## Verifying this change


Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] satansk commented on pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["satansk (GitHub)" <gi...@apache.org>]

I have a doubt here, what name to choose when we have another new Router?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory closed pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["cvictory (GitHub)" <gi...@apache.org>]

[ pull request closed by cvictory ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on issue #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["cvictory (GitHub)" <gi...@apache.org>]

1. Every Route Impl should config priority? 
2. https://github.com/apache/incubator-dubbo/issues/3249

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["cvictory (GitHub)" <gi...@apache.org>]

NullPointException for getUrl

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["chickenlj (GitHub)" <gi...@apache.org>]

Maybe we can call it `27xRoute`r or `ApacheRouter`, what do you think？

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["cvictory (GitHub)" <gi...@apache.org>]

note， a.compareTo(b)   is not equivalent  b.compareTo(a) 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3240: Extract compareTo impl to Router interface and concrete Router only responsible for provide priority.

["cvictory (GitHub)" <gi...@apache.org>]

This is unit test.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3240 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org