You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 08:37:28 UTC
[GitHub] [arrow] fxcoudert opened a new pull request #8492: Allow LLVM 11
fxcoudert opened a new pull request #8492:
URL: https://github.com/apache/arrow/pull/8492
Homebrew now ships LLVM 11. This prevents us rebuilding arrow from source:
```
CMake Warning at cmake_modules/FindLLVMAlt.cmake:27 (find_package):
Could not find a configuration file for package "LLVM" that is compatible
with requested version "10".
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pprudhvi commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713686157
@kou looks like this requires code changes, will we be able to build gandiva on centos with llvm 8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
terencehonles commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713201184
Following up after the discussion in https://github.com/Homebrew/homebrew-core/pull/63177#issuecomment-713157947 it looks like supporting LLVM 11 would be a good idea in the long term it is no longer a blocker to compiling arrow from source.
(I was able to fix this for the GitHub workflow by updating the [cpp/Brewfile](https://github.com/apache/arrow/pull/8386/files#diff-87eb96363e17dbc9cb816c99123f76f25d63eb48920dd785a486ee59ee1997a1L28-R28) to only reference llvm@8 instead of llvm@8 and llvm)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-712699029
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-714147660
> will we be able to build gandiva on centos with llvm 8?
I think so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
terencehonles commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713099341
It looks like there are more changes needed since the builder is still broken https://github.com/apache/arrow/pull/8492/checks?check_run_id=1279869182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8492:
URL: https://github.com/apache/arrow/pull/8492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-716042133
#8521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8492: Allow LLVM 11
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713315228
@fxcoudert Thanks for sending feedback from Homebrew!
I think that we need more changes to support LLVM 11 like we did by 6a1cdbc66c5ddfaeb426ac4deea9da0ea284849f for LLVM 10.
It may be difficult for people who don't familiar with Apache Arrow build system. I'll take over this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org